From b084d4e770c3632193193994536e35ca5d9ab751 Mon Sep 17 00:00:00 2001 From: Eric Fleming Date: Fri, 1 Mar 2019 22:07:46 -0500 Subject: [PATCH] Removing List and all the places it was used --- src/ApplicationCore/Interfaces/IRepository.cs | 1 - src/Web/Services/CatalogService.cs | 14 +++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/ApplicationCore/Interfaces/IRepository.cs b/src/ApplicationCore/Interfaces/IRepository.cs index ba65c55..5f7f95c 100644 --- a/src/ApplicationCore/Interfaces/IRepository.cs +++ b/src/ApplicationCore/Interfaces/IRepository.cs @@ -6,7 +6,6 @@ namespace Microsoft.eShopWeb.ApplicationCore.Interfaces public interface IRepository where T : BaseEntity { T GetSingleBySpec(ISpecification spec); - IEnumerable List(ISpecification spec); T Add(T entity); void Update(T entity); void Delete(T entity); diff --git a/src/Web/Services/CatalogService.cs b/src/Web/Services/CatalogService.cs index ad7fbeb..5229aa5 100644 --- a/src/Web/Services/CatalogService.cs +++ b/src/Web/Services/CatalogService.cs @@ -18,14 +18,14 @@ namespace Microsoft.eShopWeb.Web.Services public class CatalogService : ICatalogService { private readonly ILogger _logger; - private readonly IRepository _itemRepository; + private readonly IAsyncRepository _itemRepository; private readonly IAsyncRepository _brandRepository; private readonly IAsyncRepository _typeRepository; private readonly IUriComposer _uriComposer; public CatalogService( ILoggerFactory loggerFactory, - IRepository itemRepository, + IAsyncRepository itemRepository, IAsyncRepository brandRepository, IAsyncRepository typeRepository, IUriComposer uriComposer) @@ -46,13 +46,13 @@ namespace Microsoft.eShopWeb.Web.Services new CatalogFilterPaginatedSpecification(itemsPage * pageIndex, itemsPage, brandId, typeId); // the implementation below using ForEach and Count. We need a List. - var itemsOnPage = _itemRepository.List(filterPaginatedSpecification).ToList(); - var totalItems = _itemRepository.Count(filterSpecification); + var itemsOnPage = await _itemRepository.ListAsync(filterPaginatedSpecification); + var totalItems = await _itemRepository.CountAsync(filterSpecification); - itemsOnPage.ForEach(x => + foreach (var itemOnPage in itemsOnPage) { - x.PictureUri = _uriComposer.ComposePicUri(x.PictureUri); - }); + itemOnPage.PictureUri = _uriComposer.ComposePicUri(itemOnPage.PictureUri); + } var vm = new CatalogIndexViewModel() {