Nell/eShopOnWeb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor cleanup (#63)

Browse Source
This commit is contained in:
Steve Smith
2017-10-23 12:11:55 -04:00
committed by GitHub
parent 16a6f83ef4
commit 749a37d6d9
5 changed files with 24 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/ApplicationCore/Entities/OrderAggregate/Address.cs
View File

@@ -25,15 +25,5 @@ namespace ApplicationCore.Entities.OrderAggregate
Country = country;
ZipCode = zipcode;
}
//protected override IEnumerable<object> GetAtomicValues()
//{
// yield return Street;
// yield return City;
// yield return State;
// yield return Country;
// yield return ZipCode;
//}
}
}

2
src/ApplicationCore/Entities/OrderAggregate/Order.cs
View File

@@ -28,7 +28,7 @@ namespace ApplicationCore.Entities.OrderAggregate
// but only through the method Order.AddOrderItem() which includes behavior.
private readonly List<OrderItem> _orderItems = new List<OrderItem>();
public IReadOnlyCollection<OrderItem> OrderItems => _orderItems;
public IReadOnlyCollection<OrderItem> OrderItems => _orderItems.AsReadOnly();
// Using List<>.AsReadOnly()
// This will create a read only wrapper around the private list so is protected against "external updates".
// It's much cheaper than .ToList() because it will not have to copy all items in a new collection. (Just one heap alloc for the wrapper instance)