From bc0f23ffff37d88f5fc536d5bf4b8b09aff19549 Mon Sep 17 00:00:00 2001 From: Srushti <136682990+SrushtiPasari94@users.noreply.github.com> Date: Tue, 17 Oct 2023 15:30:32 +0530 Subject: [PATCH 1/2] Update dotnetcore.yml updated dotnet version to build --- .github/workflows/dotnetcore.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnetcore.yml b/.github/workflows/dotnetcore.yml index d5b7ee8..3a83f96 100644 --- a/.github/workflows/dotnetcore.yml +++ b/.github/workflows/dotnetcore.yml @@ -12,7 +12,7 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v1 with: - dotnet-version: '7.0.x' + dotnet-version: '8.0.x' include-prerelease: true - name: Build with dotnet From 36746a52b725d432b0c82258b1d6a19c500d9268 Mon Sep 17 00:00:00 2001 From: Junqiao Date: Wed, 18 Oct 2023 01:42:36 +0800 Subject: [PATCH 2/2] Remove the interface ISingleResultSpecification usage from any specification (#959) ISingleResultSpecification is Obsolete Co-authored-by: junqiao.duan --- .../Specifications/BasketWithItemsSpecification.cs | 2 +- src/ApplicationCore/Specifications/OrderWithItemsByIdSpec.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ApplicationCore/Specifications/BasketWithItemsSpecification.cs b/src/ApplicationCore/Specifications/BasketWithItemsSpecification.cs index 015ca31..d597146 100644 --- a/src/ApplicationCore/Specifications/BasketWithItemsSpecification.cs +++ b/src/ApplicationCore/Specifications/BasketWithItemsSpecification.cs @@ -3,7 +3,7 @@ using Microsoft.eShopWeb.ApplicationCore.Entities.BasketAggregate; namespace Microsoft.eShopWeb.ApplicationCore.Specifications; -public sealed class BasketWithItemsSpecification : Specification, ISingleResultSpecification +public sealed class BasketWithItemsSpecification : Specification { public BasketWithItemsSpecification(int basketId) { diff --git a/src/ApplicationCore/Specifications/OrderWithItemsByIdSpec.cs b/src/ApplicationCore/Specifications/OrderWithItemsByIdSpec.cs index 2f0d888..c9b3a72 100644 --- a/src/ApplicationCore/Specifications/OrderWithItemsByIdSpec.cs +++ b/src/ApplicationCore/Specifications/OrderWithItemsByIdSpec.cs @@ -3,7 +3,7 @@ using Microsoft.eShopWeb.ApplicationCore.Entities.OrderAggregate; namespace Microsoft.eShopWeb.ApplicationCore.Specifications; -public class OrderWithItemsByIdSpec : Specification, ISingleResultSpecification +public class OrderWithItemsByIdSpec : Specification { public OrderWithItemsByIdSpec(int orderId) {