Nell/eShopOnWeb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

devcontainer fixes (#688)

Browse Source 
* adding runargs section to fix docker access from devcontainer to host

* updating integrated terminal settings to match with the most recent settings.json scheme

* updating base image to most recent dotnet sdk version

Co-authored-by: Steve Smith <steve@kentsmiths.com>
This commit is contained in:
Engin Polat
2022-12-20 10:27:01 -08:00
committed by GitHub
parent fdb1c34d61
commit 303f145ad3
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.devcontainer/Dockerfile
View File

@@ -5,6 +5,7 @@
#------------------------------------------------------------------------------------------------------------- #-------------------------------------------------------------------------------------------------------------
FROM mcr.microsoft.com/dotnet/sdk:7.0 FROM mcr.microsoft.com/dotnet/sdk:7.0
# This Dockerfile adds a non-root user with sudo access. Use the "remoteUser" # This Dockerfile adds a non-root user with sudo access. Use the "remoteUser"
# property in devcontainer.json to use it. On Linux, the container user's GID/UIDs # property in devcontainer.json to use it. On Linux, the container user's GID/UIDs
# will be updated to match your local UID/GID (when using the dockerFile property). # will be updated to match your local UID/GID (when using the dockerFile property).

12
.devcontainer/devcontainer.json
View File

@@ -15,10 +15,18 @@
// Comment out to connect as root user. See https://aka.ms/vscode-remote/containers/non-root. // Comment out to connect as root user. See https://aka.ms/vscode-remote/containers/non-root.
// make sure this is the same as USERNAME above // make sure this is the same as USERNAME above
"remoteUser": "vscode", "remoteUser": "vscode",
"runArgs": [
"-v",
"/var/run/docker.sock:/var/run/docker.sock"
],
// Set *default* container specific settings.json values on container create. // Set *default* container specific settings.json values on container create.
"settings": { "settings": {
"terminal.integrated.shell.linux": "/bin/bash" "terminal.integrated.profiles.linux": {
"bash": {
"path": "bash",
"icon": "terminal-bash"
},
},
}, },
// Add the IDs of extensions you want installed when the container is created. // Add the IDs of extensions you want installed when the container is created.