Nell/eShopOnWeb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for Nullreference exception when public api authenticate endpoint called with invalid username. (#482)

Browse Source
This commit is contained in:
Onur BIYIK
2020-11-14 22:15:08 +03:00
committed by GitHub
parent c2fe05dbd4
commit 2502e01efd
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/PublicApi/AuthEndpoints/Authenticate.cs
View File

@@ -42,7 +42,11 @@ namespace Microsoft.eShopWeb.PublicApi.AuthEndpoints
response.IsNotAllowed = result.IsNotAllowed; response.IsNotAllowed = result.IsNotAllowed;
response.RequiresTwoFactor = result.RequiresTwoFactor; response.RequiresTwoFactor = result.RequiresTwoFactor;
response.Username = request.Username; response.Username = request.Username;
response.Token = await _tokenClaimsService.GetTokenAsync(request.Username);
if (result.Succeeded)
{
response.Token = await _tokenClaimsService.GetTokenAsync(request.Username);
}
return response; return response;
} }

3
tests/FunctionalTests/PublicApi/AuthEndpoints/AuthenticateEndpoint.cs
View File

@@ -24,6 +24,7 @@ namespace Microsoft.eShopWeb.FunctionalTests.Web.Controllers
[Theory] [Theory]
[InlineData("demouser@microsoft.com", AuthorizationConstants.DEFAULT_PASSWORD, true)] [InlineData("demouser@microsoft.com", AuthorizationConstants.DEFAULT_PASSWORD, true)]
[InlineData("demouser@microsoft.com", "badpassword", false)] [InlineData("demouser@microsoft.com", "badpassword", false)]
[InlineData("baduser@microsoft.com", "badpassword", false)]
public async Task ReturnsExpectedResultGivenCredentials(string testUsername, string testPassword, bool expectedResult) public async Task ReturnsExpectedResultGivenCredentials(string testUsername, string testPassword, bool expectedResult)
{ {
var request = new AuthenticateRequest() var request = new AuthenticateRequest()
@@ -38,6 +39,6 @@ namespace Microsoft.eShopWeb.FunctionalTests.Web.Controllers
var model = stringResponse.FromJson<AuthenticateResponse>(); var model = stringResponse.FromJson<AuthenticateResponse>();
Assert.Equal(expectedResult, model.Result); Assert.Equal(expectedResult, model.Result);
} }
} }
} }