Refactoring Services (#61)

* Refactoring ViewModels into Razor Pages models

* Cleaning up Basket viewcomponent

* Refactoring services.
Fixed bug in basket item counter.

src/Web/Services/BasketViewModelService.cs

@@ -9,21 +9,18 @@ using System.Threading.Tasks;
 
 namespace Microsoft.eShopWeb.Services
 {
-    public class BasketService : IBasketService
+    public class BasketViewModelService : IBasketViewModelService
     {
         private readonly IAsyncRepository<Basket> _basketRepository;
         private readonly IUriComposer _uriComposer;
-        private readonly IAppLogger<BasketService> _logger;
         private readonly IRepository<CatalogItem> _itemRepository;
 
-        public BasketService(IAsyncRepository<Basket> basketRepository,
+        public BasketViewModelService(IAsyncRepository<Basket> basketRepository,
             IRepository<CatalogItem> itemRepository,
-            IUriComposer uriComposer,
-            IAppLogger<BasketService> logger)
+            IUriComposer uriComposer)
         {
             _basketRepository = basketRepository;
             _uriComposer = uriComposer;
-            this._logger = logger;
             _itemRepository = itemRepository;
         }
 
@@ -63,7 +60,7 @@ namespace Microsoft.eShopWeb.Services
             return viewModel;
         }
 
-        public async Task<BasketViewModel> CreateBasketForUser(string userId)
+        private async Task<BasketViewModel> CreateBasketForUser(string userId)
         {
             var basket = new Basket() { BuyerId = userId };
             await _basketRepository.AddAsync(basket);
@@ -75,44 +72,5 @@ namespace Microsoft.eShopWeb.Services
                 Items = new List<BasketItemViewModel>()
             };
         }
-
-        public async Task AddItemToBasket(int basketId, int catalogItemId, decimal price, int quantity)
-        {
-            var basket = await _basketRepository.GetByIdAsync(basketId);
-
-            basket.AddItem(catalogItemId, price, quantity);
-
-            await _basketRepository.UpdateAsync(basket);
-        }
-
-        public async Task SetQuantities(int basketId, Dictionary<string,int> quantities)
-        {
-            var basket = await _basketRepository.GetByIdAsync(basketId);
-            foreach (var item in basket.Items)
-            {
-                if (quantities.TryGetValue(item.Id.ToString(), out var quantity))
-                {
-                    _logger.LogWarning($"Updating quantity of item ID:{item.Id} to {quantity}.");
-                    item.Quantity = quantity;
-                }
-            }
-            await _basketRepository.UpdateAsync(basket);
-        }
-
-        public async Task DeleteBasketAsync(int basketId)
-        {
-            var basket = await _basketRepository.GetByIdAsync(basketId);
-            
-            await _basketRepository.DeleteAsync(basket);
-        }
-
-        public async Task TransferBasketAsync(string anonymousId, string userName)
-        {
-            var basketSpec = new BasketWithItemsSpecification(anonymousId);
-            var basket = (await _basketRepository.ListAsync(basketSpec)).FirstOrDefault();
-            if (basket == null) return;
-            basket.BuyerId = userName;
-            await _basketRepository.UpdateAsync(basket);
-        }
     }
 }

src/Web/Services/CatalogService.cs

@@ -11,6 +11,10 @@ using ApplicationCore.Specifications;
 
 namespace Microsoft.eShopWeb.Services
 {
+    /// <summary>
+    /// This is a UI-specific service so belongs in UI project. It does not contain any business logic and works
+    /// with UI-specific types (view models and SelectListItem types).
+    /// </summary>
     public class CatalogService : ICatalogService
     {
         private readonly ILogger<CatalogService> _logger;