Nell/eShopOnWeb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #242 from dotnet-architecture/remove-unused-dependency

Browse Source 
BasketService no onger uses UriComposer
This commit is contained in:
Eric Fleming
2019-04-19 11:08:03 -04:00
committed by GitHub
parent c0f0cf3a1a 693c6c4466
commit 1632f7fb75
4 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ApplicationCore/Services/BasketService.cs
View File

@@ -2,7 +2,6 @@
using System.Threading.Tasks; using System.Threading.Tasks;
using System.Collections.Generic; using System.Collections.Generic;
using Microsoft.eShopWeb.ApplicationCore.Specifications; using Microsoft.eShopWeb.ApplicationCore.Specifications;
using Microsoft.eShopWeb.ApplicationCore.Entities;
using System.Linq; using System.Linq;
using Ardalis.GuardClauses; using Ardalis.GuardClauses;
using Microsoft.eShopWeb.ApplicationCore.Entities.BasketAggregate; using Microsoft.eShopWeb.ApplicationCore.Entities.BasketAggregate;
@@ -13,16 +12,13 @@ namespace Microsoft.eShopWeb.ApplicationCore.Services
{ {
private readonly IAsyncRepository<Basket> _basketRepository; private readonly IAsyncRepository<Basket> _basketRepository;
private readonly IAsyncRepository<BasketItem> _basketItemRepository; private readonly IAsyncRepository<BasketItem> _basketItemRepository;
private readonly IUriComposer _uriComposer;
private readonly IAppLogger<BasketService> _logger; private readonly IAppLogger<BasketService> _logger;
public BasketService(IAsyncRepository<Basket> basketRepository, public BasketService(IAsyncRepository<Basket> basketRepository,
IUriComposer uriComposer,
IAppLogger<BasketService> logger, IAppLogger<BasketService> logger,
IAsyncRepository<BasketItem> basketItemRepository) IAsyncRepository<BasketItem> basketItemRepository)
{ {
_basketRepository = basketRepository; _basketRepository = basketRepository;
_uriComposer = uriComposer;
_logger = logger; _logger = logger;
_basketItemRepository = basketItemRepository; _basketItemRepository = basketItemRepository;
} }

2
tests/UnitTests/ApplicationCore/Services/BasketServiceTests/DeleteBasket.cs
View File

@@ -26,7 +26,7 @@ namespace Microsoft.eShopWeb.UnitTests.ApplicationCore.Services.BasketServiceTes
basket.AddItem(2, It.IsAny<decimal>(), It.IsAny<int>()); basket.AddItem(2, It.IsAny<decimal>(), It.IsAny<int>());
_mockBasketRepo.Setup(x => x.GetByIdAsync(It.IsAny<int>())) _mockBasketRepo.Setup(x => x.GetByIdAsync(It.IsAny<int>()))
.ReturnsAsync(basket); .ReturnsAsync(basket);
var basketService = new BasketService(_mockBasketRepo.Object, null, null, _mockBasketItemRepo.Object); var basketService = new BasketService(_mockBasketRepo.Object, null, _mockBasketItemRepo.Object);
await basketService.DeleteBasketAsync(It.IsAny<int>()); await basketService.DeleteBasketAsync(It.IsAny<int>());

4
tests/UnitTests/ApplicationCore/Services/BasketServiceTests/SetQuantities.cs
View File

@@ -21,7 +21,7 @@ namespace Microsoft.eShopWeb.UnitTests.ApplicationCore.Services.BasketServiceTes
[Fact] [Fact]
public async void ThrowsGivenInvalidBasketId() public async void ThrowsGivenInvalidBasketId()
{ {
var basketService = new BasketService(_mockBasketRepo.Object, null, null, null); var basketService = new BasketService(_mockBasketRepo.Object, null, null);
await Assert.ThrowsAsync<BasketNotFoundException>(async () => await Assert.ThrowsAsync<BasketNotFoundException>(async () =>
await basketService.SetQuantities(_invalidId, new System.Collections.Generic.Dictionary<string, int>())); await basketService.SetQuantities(_invalidId, new System.Collections.Generic.Dictionary<string, int>()));
@@ -30,7 +30,7 @@ namespace Microsoft.eShopWeb.UnitTests.ApplicationCore.Services.BasketServiceTes
[Fact] [Fact]
public async void ThrowsGivenNullQuantities() public async void ThrowsGivenNullQuantities()
{ {
var basketService = new BasketService(null, null, null, null); var basketService = new BasketService(null, null, null);
await Assert.ThrowsAsync<ArgumentNullException>(async () => await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await basketService.SetQuantities(123, null)); await basketService.SetQuantities(123, null));

4
tests/UnitTests/ApplicationCore/Services/BasketServiceTests/TransferBasket.cs
View File

@@ -9,7 +9,7 @@ namespace Microsoft.eShopWeb.UnitTests.ApplicationCore.Services.BasketServiceTes
[Fact] [Fact]
public async void ThrowsGivenNullAnonymousId() public async void ThrowsGivenNullAnonymousId()
{ {
var basketService = new BasketService(null, null, null, null); var basketService = new BasketService(null, null, null);
await Assert.ThrowsAsync<ArgumentNullException>(async () => await basketService.TransferBasketAsync(null, "steve")); await Assert.ThrowsAsync<ArgumentNullException>(async () => await basketService.TransferBasketAsync(null, "steve"));
} }
@@ -17,7 +17,7 @@ namespace Microsoft.eShopWeb.UnitTests.ApplicationCore.Services.BasketServiceTes
[Fact] [Fact]
public async void ThrowsGivenNullUserId() public async void ThrowsGivenNullUserId()
{ {
var basketService = new BasketService(null, null, null, null); var basketService = new BasketService(null, null, null);
await Assert.ThrowsAsync<ArgumentNullException>(async () => await basketService.TransferBasketAsync("abcdefg", null)); await Assert.ThrowsAsync<ArgumentNullException>(async () => await basketService.TransferBasketAsync("abcdefg", null));
} }